Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C++ Simulation to match Java #1026

Merged
merged 18 commits into from
Dec 16, 2023
Merged

Update C++ Simulation to match Java #1026

merged 18 commits into from
Dec 16, 2023
+5,123 −15

Conversation

r4stered
Copy link
Contributor

@r4stered r4stered commented Nov 25, 2023 •
edited
Loading

This is a PR that updates the C++ version of Photonlib to support the new simulation features.

TODO:

  • Example project

@srimanachanta srimanachanta linked an issue Nov 26, 2023 that may be closed by this pull request
Update C++ Simulation #941
Closed
@srimanachanta
Copy link
Member

This wasn't based correctly so make sure to merge with master as some stuff is missing.

@r4stered
Copy link
Contributor Author

This wasn't based correctly so make sure to merge with master as some stuff is missing.

On my fork it says its ahead by 11 commits with master branch. What is missing?

@srimanachanta
Copy link
Member

This wasn't based correctly so make sure to merge with master as some stuff is missing.

On my fork it says its ahead by 11 commits with master branch. What is missing?

Sync your master branch with our master branch. There should be a button

@r4stered
Copy link
Contributor Author

This wasn't based correctly so make sure to merge with master as some stuff is missing.

On my fork it says its ahead by 11 commits with master branch. What is missing?

Sync your master branch with our master branch. There should be a button

I see that button, but it says its up to date

image

@mcm001
Copy link
Contributor

mcm001 commented Nov 27, 2023

This wasn't based correctly so make sure to merge with master as some stuff is missing.

It looks OK to me? What am I missing

@mcm001
Copy link
Contributor

mcm001 commented Dec 1, 2023 •
edited
Loading

Just blocked waiting for a wpilib beta release rn I believe

@mcm001 mcm001 marked this pull request as ready for review December 16, 2023 18:37
@mcm001 mcm001 requested a review from a team as a code owner December 16, 2023 18:37
mcm001
mcm001 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imagine actually reviewing PRs

@mcm001 mcm001 merged commit cba4db0 into PhotonVision:master Dec 16, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srimanachanta srimanachanta srimanachanta left review comments

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update C++ Simulation
3 participants
@r4stered @srimanachanta @mcm001